Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127363003: Insert the right checks for redirecting factories to deferred constructors. (Closed)

Created:
5 years, 7 months ago by sigurdm
Modified:
5 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Insert the right checks for redirecting factories to deferred constructors. BUG=https://code.google.com/p/dart/issues/detail?id=23399 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45637

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address review #

Patch Set 3 : update to status-file rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -28 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 9 chunks +39 lines, -21 lines 0 comments Download
M tests/language/deferred_inheritance_constraints_test.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A tests/language/deferred_redirecting_factory_lib1.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests/language/deferred_redirecting_factory_lib2.dart View 1 chunk +4 lines, -5 lines 0 comments Download
A tests/language/deferred_redirecting_factory_test.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
5 years, 7 months ago (2015-05-08 07:27:39 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1127363003/diff/20001/tests/language/deferred_redirecting_factory_test.dart File tests/language/deferred_redirecting_factory_test.dart (right): https://codereview.chromium.org/1127363003/diff/20001/tests/language/deferred_redirecting_factory_test.dart#newcode45 tests/language/deferred_redirecting_factory_test.dart:45: // await test3(); Remove comment. Maybe make each ...
5 years, 7 months ago (2015-05-08 08:41:58 UTC) #4
sigurdm
https://codereview.chromium.org/1127363003/diff/20001/tests/language/deferred_redirecting_factory_test.dart File tests/language/deferred_redirecting_factory_test.dart (right): https://codereview.chromium.org/1127363003/diff/20001/tests/language/deferred_redirecting_factory_test.dart#newcode45 tests/language/deferred_redirecting_factory_test.dart:45: // await test3(); On 2015/05/08 08:41:58, Johnni Winther wrote: ...
5 years, 7 months ago (2015-05-08 09:17:35 UTC) #5
sigurdm
5 years, 7 months ago (2015-05-08 09:18:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as 45637 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698