Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11273041: Make first and last getters. (Closed)

Created:
8 years, 1 month ago by floitsch
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make first and last getters. Committed: https://code.google.com/p/dart/source/detail?r=14082

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update status files with co19 issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -243 lines) Patch
M lib/compiler/implementation/dart_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/js/printer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/source_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/bailout.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/ssa/tracer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/util/uri_extras.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/queue.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/core/sequences.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/queue.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 51 chunks +52 lines, -52 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 51 chunks +52 lines, -52 lines 0 comments Download
M lib/html/scripts/idlrenderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/templates/html/impl/impl_Node.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/templates/html/impl/impl_NodeList.darttemplate View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/html/templates/immutable_list_mixin.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/markdown/block_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/markdown/inline_parser.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/intl/lib/src/date_format_field.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/tool/generate_locale_data_files.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/mock.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/buffer_list.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/http_impl.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/path_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/string_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/calculator/calculator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/calculator/tape.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/block_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/inline_parser.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples/tests/samples/lib/observable/observable_list_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-html.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M samples/third_party/dromaeo/tests/dom-traverse-htmlidiomatic.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/ui_lib/observable/observable.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/touch/Momentum.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tests/corelib/queue_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/documentfragment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/node_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/selectelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/generic_creation_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/extract.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/lib/file_system.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M utils/pub/io.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/pub/yaml/parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/template/codegen.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M utils/template/htmltree.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/template/real_app.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 1 month ago (2012-10-25 14:13:36 UTC) #1
Mads Ager (google)
LGTM https://codereview.chromium.org/11273041/diff/1/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (right): https://codereview.chromium.org/11273041/diff/1/tests/co19/co19-compiler.status#newcode213 tests/co19/co19-compiler.status:213: # The following tests use first|last as function ...
8 years, 1 month ago (2012-10-25 14:21:23 UTC) #2
floitsch
8 years, 1 month ago (2012-10-25 15:16:22 UTC) #3 
https://codereview.chromium.org/11273041/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/11273041/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:213: # The following tests use first|last as
function instead of as getters.
On 2012/10/25 14:21:23, Mads Ager wrote:
> co19 bug report when committing.

Done.

Powered by Google App Engine
This is Rietveld 408576698