Issue 11273018: Add crypto_android.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11273018: Add crypto_android.cc (Closed)

Created:
8 years, 2 months ago by vsm

Modified:
8 years, 1 month ago

Reviewers:
gram, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add crypto_android.cc This fixes the android build of the command line embedder. Committed: https://code.google.com/p/dart/source/detail?r=14045

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, --1 lines)			Patch
	M	runtime/bin/builtin_impl_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	runtime/bin/crypto_android.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gram

On 2012/10/24 19:49:18, gram wrote: > lgtm, thanks! Although I should not I'm not sure ...

8 years, 2 months ago (2012-10-24 19:50:04 UTC) #3

vsm

8 years, 1 month ago (2012-10-24 22:19:51 UTC) #4

On 2012/10/24 19:50:04, gram wrote:
> On 2012/10/24 19:49:18, gram wrote:
> > lgtm, thanks!
> 
> Although I should not I'm not sure it will actually work - is there a
> /dev/random on Android?

It (/dev/random and /dev/urandom) is there on my device.

Thanks, landing.

Expand Messages | Collapse Messages