Issue 11273006: Move StopwatchImplementation from coreimpl to core as _StopwatchImpl.

Issue 11273006: Move StopwatchImplementation from coreimpl to core as _StopwatchImpl. (Closed)

Created:
8 years, 2 months ago by Anders Johnsen

Modified:
8 years, 1 month ago

Reviewers:
floitsch, Ivan Posva

CC:
reviews_dartlang.org, Mads Ager (google), Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move StopwatchImplementation from coreimpl to core as _StopwatchImpl. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14182

Patch Set 1 #

Total comments: 5

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -86 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	lib/core/stopwatch.dart	View	2 chunks	+67 lines, -1 line	5 comments	Download
M	lib/coreimpl/coreimpl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/stopwatch_implementation.dart	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/stopwatch_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11273006/diff/1/lib/core/stopwatch.dart File lib/core/stopwatch.dart (right): https://codereview.chromium.org/11273006/diff/1/lib/core/stopwatch.dart#newcode71 lib/core/stopwatch.dart:71: // If _stop is null, then the [Stopwatch] ...

8 years, 2 months ago (2012-10-24 11:03:29 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/11273006/diff/1/lib/core/stopwatch.dart File lib/core/stopwatch.dart (right): https://codereview.chromium.org/11273006/diff/1/lib/core/stopwatch.dart#newcode71 lib/core/stopwatch.dart:71: // If _stop is null, then the [Stopwatch] ...

8 years, 2 months ago (2012-10-24 12:19:55 UTC) #3

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/11273006/diff/1/lib/core/stopwatch.dart File lib/core/stopwatch.dart (right): https://chromiumcodereview.appspot.com/11273006/diff/1/lib/core/stopwatch.dart#newcode71 lib/core/stopwatch.dart:71: // If _stop is null, then the ...

8 years, 1 month ago (2012-10-26 02:52:26 UTC) #4

floitsch

8 years, 1 month ago (2012-10-26 09:25:15 UTC) #5

https://chromiumcodereview.appspot.com/11273006/diff/1/lib/core/stopwatch.dart
File lib/core/stopwatch.dart (right):

https://chromiumcodereview.appspot.com/11273006/diff/1/lib/core/stopwatch.dar...
lib/core/stopwatch.dart:71: // If _stop is null, then the [Stopwatch] has not
been stopped yet,
On 2012/10/26 02:52:26, Ivan Posva wrote:
> On 2012/10/24 11:03:30, floitsch wrote:
> > has not been started yet, or is running. (NYC)
> Florian, care to explain this?
It was just a different way of saying the same thing. But we will keep it as is.

Expand Messages | Collapse Messages