Handle compound operators.

Handle compound operators.

Committed: https://code.google.com/p/dart/source/detail?r=14682

[karlklose, 2012-11-08 10:45:31]

LGTM with a few comments.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
File lib/compiler/implementation/types/concrete_types_inferrer.dart (right):

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:992: environment
= environment.put(receiver, argumentType);
Do we keep track of the type of AbstractFields?

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1008:
(fieldOrSetter as AbstractFieldElement).setter;
We usually assign to a variable instead of using as. (A cast includes a type
check).

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1009: // TODO:
uncomment if we add an effect system
"TODO(polux)". Also, can you extend the comment to explain why the call should
be there?

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1017: for (final
member in inferrer.getMembersByName(source)) {
Please type the loop variable.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1018: Element
classElem = member.enclosingElement;
Does this work for fields? Their enclosing member is a variable definition,
isn't it? I think you should use getEnclosingClass.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1049: new
ArgumentsTypes(positionalArguments, new Map());
How about using {} isntead of new Map()?

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1402:
SourceString canonicalizedMethodName =
Consider simply calling the variable 'name'. That would make the rest of the
method easier to read.

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/cpa_inference_test.dart (right):

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:548: var _x;
It is unnecessary to use privacy here; using a normal would perhaps make the
test easier to understand.

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:550: var witness2;
witness2 is unused. Did you want to use it in the setter and the second test?

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:566:
result.checkFieldHasType('A', 'witness1', [result.string]);
witness2?

[polux, 2012-11-08 14:04:50]

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
File lib/compiler/implementation/types/concrete_types_inferrer.dart (right):

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:992: environment
= environment.put(receiver, argumentType);
On 2012/11/08 10:45:31, karlklose wrote:
> Do we keep track of the type of AbstractFields?

Good catch! Added a test. Discovered a similar issue with getters, fixed it and
added a test too.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1008:
(fieldOrSetter as AbstractFieldElement).setter;
On 2012/11/08 10:45:31, karlklose wrote:
> We usually assign to a variable instead of using as. (A cast includes a type
> check).

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1009: // TODO:
uncomment if we add an effect system
On 2012/11/08 10:45:31, karlklose wrote:
> "TODO(polux)". Also, can you extend the comment to explain why the call should
> be there?

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1017: for (final
member in inferrer.getMembersByName(source)) {
On 2012/11/08 10:45:31, karlklose wrote:
> Please type the loop variable.

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1018: Element
classElem = member.enclosingElement;
On 2012/11/08 10:45:31, karlklose wrote:
> Does this work for fields? Their enclosing member is a variable definition,
> isn't it? I think you should use getEnclosingClass.

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1049: new
ArgumentsTypes(positionalArguments, new Map());
On 2012/11/08 10:45:31, karlklose wrote:
> How about using {} isntead of new Map()?

This would evaluate to <String,dynamic>{} and would break in checked mode.

https://chromiumcodereview.appspot.com/11272032/diff/1/lib/compiler/implement...
lib/compiler/implementation/types/concrete_types_inferrer.dart:1402:
SourceString canonicalizedMethodName =
On 2012/11/08 10:45:31, karlklose wrote:
> Consider simply calling the variable 'name'. That would make the rest of the
> method easier to read.

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/cpa_inference_test.dart (right):

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:548: var _x;
On 2012/11/08 10:45:31, karlklose wrote:
> It is unnecessary to use privacy here; using a normal would perhaps make the
> test easier to understand.

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:550: var witness2;
On 2012/11/08 10:45:31, karlklose wrote:
> witness2 is unused. Did you want to use it in the setter and the second test?

Done.

https://chromiumcodereview.appspot.com/11272032/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:566:
result.checkFieldHasType('A', 'witness1', [result.string]);
On 2012/11/08 10:45:31, karlklose wrote:
> witness2?

Done.