Issue 11272028: Simplify the implementation and generated code for the IC stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11272028: Simplify the implementation and generated code for the IC stubs. (Closed)

Created:
8 years, 1 month ago by Kevin Millikin (Google)

Modified:
8 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify the implementation and generated code for the IC stubs. The implementation now uses the same code for 1 and >1 argument cases. For the 1 argument case the generated code is essentially the same code as before. For the >1 argument case the generated code is slightly improved. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14249

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -107 lines)			Patch
	M	runtime/vm/stub_code_ia32.cc	View		2 chunks	+56 lines, -53 lines	0 comments	Download
	M	runtime/vm/stub_code_x64.cc	View		2 chunks	+58 lines, -54 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This will make it easier to use MRU (or some other sorting) for the polymorphic ...

8 years, 1 month ago (2012-10-25 12:01:20 UTC) #1

Florian Schneider

8 years, 1 month ago (2012-10-25 12:41:31 UTC) #2

lgtm

http://codereview.chromium.org/11272028/diff/1/runtime/vm/stub_code_x64.cc
File runtime/vm/stub_code_x64.cc (right):

http://codereview.chromium.org/11272028/diff/1/runtime/vm/stub_code_x64.cc#ne...
runtime/vm/stub_code_x64.cc:1612: __ movq(RAX, FieldAddress(R10,
Array::data_offset()));
Could you keep FieldAddress(R10, Array::data_offset()) in a register on x64?
There should be plenty available.

Expand Messages | Collapse Messages