Issue 11272022: Fix return code on Windows 8 machines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11272022: Fix return code on Windows 8 machines. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix return code on Windows 8 machines. Committed: https://code.google.com/p/dart/source/detail?r=14056

Patch Set 2 : #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	tools/bots/compiler.py	View	1	4 chunks	+7 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This was causing the Win8 Opera machine to try the second branch, delete /var/tmp, and ...

8 years, 2 months ago (2012-10-25 00:06:46 UTC) #1

Bob Nystrom

One question, but LGTM either way. https://codereview.chromium.org/11272022/diff/2001/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/11272022/diff/2001/tools/bots/compiler.py#newcode263 tools/bots/compiler.py:263: if (build_info.system.startswith('win') and ...

8 years, 2 months ago (2012-10-25 00:32:54 UTC) #2