Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127173004: Use regular sources to load dart:io and builtin library instead of linking in the standalone dart s… (Closed)

Created:
5 years, 7 months ago by siva
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use regular sources to load dart:io and builtin library instead of linking in the standalone dart snapshot for accessing these. This ensures that we can use the regular dartium snapshot to create the vmservice isolate. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/bin/vmservice_dartium.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice_dartium.cc View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 7 months ago (2015-05-14 00:00:35 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-14 00:51:12 UTC) #3
siva
5 years, 7 months ago (2015-05-14 17:40:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r45788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698