Issue 11271016: Enable Opera tests.

Issue 11271016: Enable Opera tests. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
Jennifer Messerly, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable Opera tests. Committed: https://code.google.com/p/dart/source/detail?r=14091

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -29 lines)			Patch
M	pkg/pkg.status	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	samples/tests/samples/samples.status	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/benchmark_smoke/benchmark_smoke.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	1	2 chunks	+37 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/json/json.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm! awesome! https://codereview.chromium.org/11271016/diff/2001/samples/tests/samples/samples.status File samples/tests/samples/samples.status (right): https://codereview.chromium.org/11271016/diff/2001/samples/tests/samples/samples.status#newcode59 samples/tests/samples/samples.status:59: lib/touch/touch_test: Fail # Expectation: Solver. Expect.approxEquals(expected:9, actual:8.990625000000001, ...

8 years, 1 month ago (2012-10-25 02:13:38 UTC) #2

kasperl

8 years, 1 month ago (2012-10-25 09:28:31 UTC) #3

Thanks a lot, Emily!

https://codereview.chromium.org/11271016/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11271016/diff/2001/tests/html/html.status#new...
tests/html/html.status:218: fileapi_test: Skip
It might be nice with a comment that explains why these need to be skipped?

https://codereview.chromium.org/11271016/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11271016/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:63: isolate2_negative_test: Skip
It might be nice with a comment that explains why these need to be skipped?

https://codereview.chromium.org/11271016/diff/2001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11271016/diff/2001/tests/language/language_da...
tests/language/language_dart2js.status:364:
closure_call_wrong_argument_count_negative_test: Skip
It might be nice with a comment that explains why these need to be skipped?

Expand Messages | Collapse Messages