Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1127043002: Fix SplayTreeMap.from ignoring the compare and isValidKey arguments. (Closed)

Created:
5 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 7 months ago
Reviewers:
wibling
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix SplayTreeMap.from ignoring the compare and isValidKey arguments. BUG= http://dartbug.com/23387 R=wibling@google.com Committed: https://code.google.com/p/dart/source/detail?r=45550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/splay_tree_test.dart View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-06 07:08:06 UTC) #2
wibling
lgtm
5 years, 7 months ago (2015-05-06 08:06:15 UTC) #3
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-06 08:19:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698