Issue 1127023003: Avoid using multitest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127023003: Avoid using multitest. (Closed)

Created:
5 years, 7 months ago by sigurdm

Modified:
5 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Avoid using multitest. This test did not work as a multitest, because the deferred_redirecting_factory_lib1.dart imports the main file - it will not find it after the splitting and renaming. Luckily it is not strictly required for the test (though somewhat cleaner) to have a multitest. BUG= Committed: https://code.google.com/p/dart/source/detail?r=45643

Patch Set 1 #

Patch Set 2 : Fix status file #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	tests/language/deferred_redirecting_factory_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	tests/language/language.status	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sigurdm

Committed patchset #2 (id:20001) manually as 45643 (presubmit successful).

5 years, 7 months ago (2015-05-08 12:09:49 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages