Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 11270008: Add type annotations to remove warnings and fix a bug. (Closed)

Created:
8 years, 2 months ago by karlklose
Modified:
8 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add type annotations to remove warnings and fix a bug. Committed: https://code.google.com/p/dart/source/detail?r=14003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M lib/compiler/implementation/dart_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 6 chunks +9 lines, -7 lines 0 comments Download
M lib/compiler/implementation/ssa/value_range_analyzer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/typechecker.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/compiler/implementation/universe/partial_type_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karlklose
8 years, 2 months ago (2012-10-24 09:26:34 UTC) #1
kasperl
8 years, 2 months ago (2012-10-24 09:43:12 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698