Added test for the behavior of InvocationMirror and noSuchMethod.

Added test for the behavior of InvocationMirror and noSuchMethod.

No implementation currently satisfy the test - it's created as a
goal for the implementations.

R=ager@google.com

Committed: https://code.google.com/p/dart/source/detail?r=14125

[Lasse Reichstein Nielsen, 2012-10-25 11:54:35]

PTAL.

[Mads Ager (google), 2012-10-25 12:32:19]

LGTM with nits.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
File tests/language/invocation_mirror_test.dart (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:32: testIM(InvocationMirror im,
String name, [List positional, Map named]) {
Write it out: testInvocationMirror?

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:62: named.forEach((k,v) {u
Could you add a space? (k, v) {

Also, the 'u' is a typo.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:68: isNSM(e) => e is
noSuchMethodError;
Write it out.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:139: Expect.throws(() { var x =
n.flif; x(37,42); }, isNSM);
Add space x(37, 42)?

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:140: Expect.throws(() { var x =
c.call; x(37,42); }, isNSM);
ditto

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
File tests/language/language.status (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
tests/language/language.status:205: # Test expects signature of noSUchMethod to
be
typo

Also, please finish comment.

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
tests/language/language.status:447: # Implement InvocationMirror and pass it to
noSuchMethod. This error might go
I don't understand this comment. Isn't the only issue here that the output of
dart2dart is run on the VM which does not have handling or noSuchMethod yet. So
marking this with the VM bug should do it. :)

https://codereview.chromium.org/11269041/diff/5001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/language_da...
tests/language/language_dart2js.status:318: invocation_mirror_test: Fail #
Implement InvocationMirror and pass it to noSuchMethod.
Move comment to line before?

[Lasse Reichstein Nielsen, 2012-10-25 14:12:00]

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
File tests/language/invocation_mirror_test.dart (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:32: testIM(InvocationMirror im,
String name, [List positional, Map named]) {
On 2012/10/25 12:32:19, Mads Ager wrote:
> Write it out: testInvocationMirror?

Done.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:62: named.forEach((k,v) {u
On 2012/10/25 12:32:19, Mads Ager wrote:
> Could you add a space? (k, v) {
> 
> Also, the 'u' is a typo.

Done.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:68: isNSM(e) => e is
noSuchMethodError;
That would be almost as long as the body, so I inlined it instead.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:139: Expect.throws(() { var x =
n.flif; x(37,42); }, isNSM);
On 2012/10/25 12:32:19, Mads Ager wrote:
> Add space x(37, 42)?

Done.

https://codereview.chromium.org/11269041/diff/5001/tests/language/invocation_...
tests/language/invocation_mirror_test.dart:140: Expect.throws(() { var x =
c.call; x(37,42); }, isNSM);
On 2012/10/25 12:32:19, Mads Ager wrote:
> ditto

Done.

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
File tests/language/language.status (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
tests/language/language.status:205: # Test expects signature of noSUchMethod to
be
On 2012/10/25 12:32:19, Mads Ager wrote:
> typo
> 
> Also, please finish comment.

Done.

https://codereview.chromium.org/11269041/diff/5001/tests/language/language.st...
tests/language/language.status:447: # Implement InvocationMirror and pass it to
noSuchMethod. This error might go
Good solution!

https://codereview.chromium.org/11269041/diff/5001/tests/language/language_da...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11269041/diff/5001/tests/language/language_da...
tests/language/language_dart2js.status:318: invocation_mirror_test: Fail #
Implement InvocationMirror and pass it to noSuchMethod.
On 2012/10/25 12:32:19, Mads Ager wrote:
> Move comment to line before?

Done.