Updated GetTimeZoneName() to return "" if localtime_r fails or has a NULL for its tm_zone value, li…

Updated GetTimeZoneName() to return "" if localtime_r fails or has a NULL for its tm_zone value, like V8 does.  Also updated GetTimeZoneOffsetInSeconds() to return 0 on localtime_r failure, like V8.


BUG=5943
Committed: https://code.google.com/p/dart/source/detail?r=14112

[siva, 2012-10-25 23:31:40]

lgtm

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc
File runtime/vm/os_android.cc (right):

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc#newco...
runtime/vm/os_android.cc:32: return succeeded && decomposed.tm_zone != NULL ?
decomposed.tm_zone : "";
suggest parens for better readability
return (succeeded && decomposed.tm_zone != NULL) ? .....

Same comment in the other files too.

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc#newco...
runtime/vm/os_android.cc:39: // Even if the offset was 24 hours it would still
easily fit into 32 bits.
Do we need to add the same comment here regarding compatibility with v8
behaviour.

[Tom Ball, 2012-10-25 23:38:11]

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc
File runtime/vm/os_android.cc (right):

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc#newco...
runtime/vm/os_android.cc:32: return succeeded && decomposed.tm_zone != NULL ?
decomposed.tm_zone : "";
On 2012/10/25 23:31:40, siva wrote:
> suggest parens for better readability
> return (succeeded && decomposed.tm_zone != NULL) ? .....
> 
> Same comment in the other files too.

Done.

http://codereview.chromium.org/11267051/diff/1/runtime/vm/os_android.cc#newco...
runtime/vm/os_android.cc:39: // Even if the offset was 24 hours it would still
easily fit into 32 bits.
On 2012/10/25 23:31:40, siva wrote:
> Do we need to add the same comment here regarding compatibility with v8
> behaviour.

Done.