Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 11267043: Small IL cleanup. (Closed)

Created:
8 years, 1 month ago by Florian Schneider
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Small IL cleanup. 1. Remove manual inlining and intrinsification of Double.toDouble and Integer.toInt. The flow graph inliner can handle these since they are not native library functions. 2. Remove unused member instance_call_ from UnarySmiOp. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=14079

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -151 lines) Patch
M runtime/vm/code_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M runtime/vm/intermediate_language.h View 6 chunks +1 line, -35 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
8 years, 1 month ago (2012-10-25 13:48:23 UTC) #1
Kevin Millikin (Google)
lgtm
8 years, 1 month ago (2012-10-25 14:17:20 UTC) #2
Florian Schneider
8 years, 1 month ago (2012-10-25 14:23:09 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698