Fix issue that cases the usesWebDriver getter in TestCase to always return false.

Fix issue that cases the usesWebDriver getter in TestCase to always return false.

Remove newly added code for timeout handling.

Make sure that timeout handling actually works so that dart2js
timing out will actually cause a timeout even when retrying
browser tests.

R=ahe@google.com,efortuna@google.com,ricow@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14014

[ahe, 2012-10-24 12:55:58]

LGTM.

Clearly, this fixes one problem, but I think there are more problems.

We expect that that, and are monitoring the bots, so please do not try to revert
this change or experiment further on the test infrastructure until we have found
the root cause of each new problem that we see.

[Emily Fortuna, 2012-10-24 17:14:48]

I'm unclear what this fixes. 

@ahe, does this mean AAR would prefer to do the debugging of these machines on
your own and I shouldn't submit any changes today? (just want to understand the
plan)

https://codereview.chromium.org/11267008/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/11267008/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:599: timeoutTimer = null;
This shouldn't be reached on the bots because the tests are run in batch mode. I
don't see how this change fixes anything?

[Emily Fortuna, 2012-10-24 17:26:22]

I remember submitting a change to fix this same thing last week. It must have
gotten reverted? lgtm, but this is not the issue that's causing problems on the
IE bots. (but glad we're making some progress)

[Mads Ager (google), 2012-10-24 17:56:03]

Thanks Emily. Please do keep looking into the windows browser bots! The only
reason I did this change was that I didn't understand the need for the previous
one and wanted to figure out what was going on. :-)

https://codereview.chromium.org/11267008/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/11267008/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:599: timeoutTimer = null;
On 2012/10/24 17:14:48, Emily Fortuna wrote:
> This shouldn't be reached on the bots because the tests are run in batch mode.
I
> don't see how this change fixes anything?

This is needed if step1 fails. I believe that only step2 which is running in the
browser is batched. If you make dart2js timeout by making the dart2js.dart main
entry point loop, the test will fail with a timeout. Then it will be retried,
and without this change dart2js will spin in the infinite loop and never be
killed. With this change dart2js compilation will timeout again and the result
of the test will be a timeout as it should be. I tested this change that way
locally before submitting.