Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1126613004: Use server.getContainingContext() in execution domain. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use server.getContainingContext() in execution domain. It works even for folders. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45504

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 7 months ago (2015-05-04 19:47:57 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1126613004/diff/1/pkg/analysis_server/lib/src/domain_execution.dart File pkg/analysis_server/lib/src/domain_execution.dart (right): https://codereview.chromium.org/1126613004/diff/1/pkg/analysis_server/lib/src/domain_execution.dart#newcode99 pkg/analysis_server/lib/src/domain_execution.dart:99: AnalysisContext context = server.getContainingContext(path); Why do we have ...
5 years, 7 months ago (2015-05-04 20:06:19 UTC) #2
scheglov
https://codereview.chromium.org/1126613004/diff/1/pkg/analysis_server/lib/src/domain_execution.dart File pkg/analysis_server/lib/src/domain_execution.dart (right): https://codereview.chromium.org/1126613004/diff/1/pkg/analysis_server/lib/src/domain_execution.dart#newcode99 pkg/analysis_server/lib/src/domain_execution.dart:99: AnalysisContext context = server.getContainingContext(path); On 2015/05/04 20:06:19, Brian Wilkerson ...
5 years, 7 months ago (2015-05-04 20:15:22 UTC) #3
scheglov
5 years, 7 months ago (2015-05-04 20:15:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45504 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698