Issue 11266046: Added API docs build target to the Pub buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11266046: Added API docs build target to the Pub buildbot. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added API docs build target to the Pub buildbot. See issue: http://code.google.com/p/dart/issues/detail?id=4989 Committed: https://code.google.com/p/dart/source/detail?r=14107

Patch Set 2 : Fixed nit. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, --1 lines)			Patch
	A	client/tools/buildbot_annotated_steps.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	tools/bots/pub.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit, otherwise LGTM. https://codereview.chromium.org/11266046/diff/1/tools/bots/pub.py File tools/bots/pub.py (right): https://codereview.chromium.org/11266046/diff/1/tools/bots/pub.py#newcode42 tools/bots/pub.py:42: bot.RunProcess(args) Nit, but can you ...

8 years, 1 month ago (2012-10-25 20:03:21 UTC) #2

Andrei Mouravski

8 years, 1 month ago (2012-10-25 22:13:39 UTC) #3

Thanks, submitting.

https://codereview.chromium.org/11266046/diff/1/tools/bots/pub.py
File tools/bots/pub.py (right):

https://codereview.chromium.org/11266046/diff/1/tools/bots/pub.py#newcode42
tools/bots/pub.py:42: bot.RunProcess(args)
On 2012/10/25 20:03:21, Bob Nystrom wrote:
> Nit, but can you add a blank line after this?

Done.

Expand Messages | Collapse Messages

Issue 11266046: Added API docs build target to the Pub buildbot. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed nit. #

Messages