Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11265028: Tolerate null from finding browser locale, re-enable tests (Closed)

Created:
8 years, 1 month ago by Alan Knight
Modified:
8 years, 1 month ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tolerate null from finding browser locale, re-enable tests Committed: https://code.google.com/p/dart/source/detail?r=14097

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M pkg/intl/lib/intl.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
Pending a fix for 6237, we can at least tolerate that IE will return null ...
8 years, 1 month ago (2012-10-25 17:55:33 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11265028/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/11265028/diff/1/pkg/pkg.status#newcode25 pkg/pkg.status:25: #intl/test/find_default_locale_browser_test: Skip # Issue 6176 why not just delete ...
8 years, 1 month ago (2012-10-25 18:03:02 UTC) #2
Alan Knight
https://codereview.chromium.org/11265028/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/11265028/diff/1/pkg/pkg.status#newcode25 pkg/pkg.status:25: #intl/test/find_default_locale_browser_test: Skip # Issue 6176 On 2012/10/25 18:03:02, Emily ...
8 years, 1 month ago (2012-10-25 18:04:45 UTC) #3
Emily Fortuna
8 years, 1 month ago (2012-10-25 18:13:56 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698