Make methods in Stopwatch getters and rename to be more consistent.

Make methods in Stopwatch getters and rename to be more consistent.

Includes:
- Stopwatch.frequency.
- Stopwatch.elapsedInMs() -> Stopwatch.elapsedMilliseconds
- Stopwatch.elapsedInUs() -> Stopwatch.elapsedMicroseconds
- Stopwatch.elapsed() -> Stopwatch.elapsedTicks

Committed: https://code.google.com/p/dart/source/detail?r=14140

[Sean Eagan, 2012-10-25 16:54:22]

A Duration getter would be useful:

Duration get elapsed;

then you could do:

stopwatch.elapsed.inMicroseconds // if Duration had microseconds
stopwatch.elapsed.inMilliseconds
stopwatch.elapsed.inSeconds
stopwatch.elapsed.inMinutes
// etc.

and there could still be a separate getter for ticks:

int get ticks;

and if creating the Duration object is too slow for some scenarios, could retain
milliseconds/microseconds getters:

int get elapsedMicroseconds; // or just microseconds
int get elapsedMilliseconds; // or just milliseconds

[floitsch, 2012-10-25 19:06:37]

On 2012/10/25 16:54:22, seaneagan1 wrote:
> A Duration getter would be useful:
> 
> Duration get elapsed;
> 
> then you could do:
> 
> stopwatch.elapsed.inMicroseconds // if Duration had microseconds
> stopwatch.elapsed.inMilliseconds
> stopwatch.elapsed.inSeconds
> stopwatch.elapsed.inMinutes
> // etc.
> 
> and there could still be a separate getter for ticks:
> 
> int get ticks;
> 
> and if creating the Duration object is too slow for some scenarios, could
retain
> milliseconds/microseconds getters:
> 
> int get elapsedMicroseconds; // or just microseconds
> int get elapsedMilliseconds; // or just milliseconds

sounds interesting. I will discuss this tomorrow with the library-team.

[floitsch, 2012-10-26 13:42:34]

Filed a bug for an "elapsed" getter to return a Duration. We can do this later:
http://dartbug.com/6296

[Mads Ager (google), 2012-10-26 13:57:59]

LGTM, with one change.

https://codereview.chromium.org/11265024/diff/4001/utils/tests/string_encodin...
File utils/tests/string_encoding/benchmark_runner.dart (right):

https://codereview.chromium.org/11265024/diff/4001/utils/tests/string_encodin...
utils/tests/string_encoding/benchmark_runner.dart:276: return new
BlockSample(count, s.elapsedInMicroseconds * 1000);
elapsedInMicroseconds -> elapsedMicroseconds

[floitsch, 2012-10-26 14:17:36]

thanks for catching that.

https://codereview.chromium.org/11265024/diff/4001/utils/tests/string_encodin...
File utils/tests/string_encoding/benchmark_runner.dart (right):

https://codereview.chromium.org/11265024/diff/4001/utils/tests/string_encodin...
utils/tests/string_encoding/benchmark_runner.dart:276: return new
BlockSample(count, s.elapsedInMicroseconds * 1000);
On 2012/10/26 13:57:59, Mads Ager wrote:
> elapsedInMicroseconds -> elapsedMicroseconds

Done.