Issue 11264032: Introduce VM API for the patching mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11264032: Introduce VM API for the patching mechanism. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Introduce VM API for the patching mechanism. This will be used to use patching for the dart:io library. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14121

Patch Set 2 : Duplicate the code instead to keep error messages. #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -0 lines)			Patch
M	runtime/include/dart_api.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+28 lines, -0 lines	2 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

https://codereview.chromium.org/11264032/diff/1004/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/11264032/diff/1004/runtime/vm/dart_api_impl.cc#newcode4425 runtime/vm/dart_api_impl.cc:4425: DART_EXPORT Dart_Handle Dart_LoadPatch(Dart_Handle library, This code is completely duplicated ...

8 years, 1 month ago (2012-10-25 10:47:45 UTC) #2

Ivan Posva

8 years, 1 month ago (2012-10-26 04:33:34 UTC) #3

LGTM -ip

https://codereview.chromium.org/11264032/diff/1004/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/11264032/diff/1004/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:4431: if (FLAG_use_cha) {
Leave it like this but note: dartbug.com/6288

Expand Messages | Collapse Messages

Issue 11264032: Introduce VM API for the patching mechanism. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Duplicate the code instead to keep error messages. #

Messages