Issue 11264024: Hopefully fix warnings of uninitialized variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11264024: Hopefully fix warnings of uninitialized variables. (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hopefully fix warnings of uninitialized variables. Committed: https://code.google.com/p/dart/source/detail?r=14053

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 2 months ago (2012-10-25 00:36:33 UTC) #2

lgtm

https://codereview.chromium.org/11264024/diff/1/runtime/vm/intrinsifier_ia32.cc
File runtime/vm/intrinsifier_ia32.cc (right):

https://codereview.chromium.org/11264024/diff/1/runtime/vm/intrinsifier_ia32....
runtime/vm/intrinsifier_ia32.cc:1101: hi_true_cond = hi_false_cond =
lo_false_cond = OVERFLOW;
It seems weird to have this initialization code after
the UNREACHABLE() statement, could you do a return false;
instead to keep the compiler happy.

Expand Messages | Collapse Messages