Set up Android build config.

Set up Android build config.
Committed: https://code.google.com/p/dart/source/detail?r=14105

[Bob Nystrom, 2012-10-25 00:49:16]

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
File client/tools/buildbot_annotated_steps.py (right):

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
client/tools/buildbot_annotated_steps.py:123: def ProcessClient(name,
client_target):
"Client" isn't very meaningful, but I like this change. Maybe just a more
generic term like "ProcessBot"?

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:36: # Here's where we'll run tests.
Make this a TODO comment.

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:50: '--os=android dart']
How about we add OS to BuildInfo and then have the BuildSDK fn in bot.py check
that and add the flag as needed? Is that the only difference between this one
and the one in bot.py?

And, now that I look at it, bot.BuildSDK can probably just take the whole
build_info object instead of splitting out the mode and system (which it doesn't
even appear to use).

[gram, 2012-10-25 00:51:36]

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
File client/tools/buildbot_annotated_steps.py (left):

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
client/tools/buildbot_annotated_steps.py:128: has_shell=False
I don't understand why this code is being removed. Is it related to the Android
change?

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:50: '--os=android dart']
The target 'dart' here is going to change so we probably want to pull that out
and make it a parameter.

[Emily Fortuna, 2012-10-25 01:33:34]

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
File client/tools/buildbot_annotated_steps.py (left):

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
client/tools/buildbot_annotated_steps.py:128: has_shell=False
On 2012/10/25 00:51:36, gram wrote:
> I don't understand why this code is being removed. Is it related to the
Android
> change?

This is for refactoring -- as mentioned in the comments on the other side, I'm
accomplishing the same thing but now you just pass in your "target handling
script name" instead of having to rewrite a separate function that simply calls
another python script in the tools/bots directory.

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
File client/tools/buildbot_annotated_steps.py (right):

https://codereview.chromium.org/11264019/diff/2001/client/tools/buildbot_anno...
client/tools/buildbot_annotated_steps.py:123: def ProcessClient(name,
client_target):
On 2012/10/25 00:49:16, Bob Nystrom wrote:
> "Client" isn't very meaningful, but I like this change. Maybe just a more
> generic term like "ProcessBot"?

Done.

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:36: # Here's where we'll run tests.
On 2012/10/25 00:49:16, Bob Nystrom wrote:
> Make this a TODO comment.

Done.

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:50: '--os=android dart']
On 2012/10/25 00:51:36, gram wrote:
> The target 'dart' here is going to change so we probably want to pull that out
> and make it a parameter.

@Bob, the difference is that the one in bot.py is building the sdk, whereas this
is building the android target, not the sdk. 

@Graham, more info, please? in what way will it change? how should it be
communicated to the buildbot?

[Bob Nystrom, 2012-10-25 16:12:16]

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:50: '--os=android dart']
On 2012/10/25 01:33:34, Emily Fortuna wrote:
> On 2012/10/25 00:51:36, gram wrote:
> > The target 'dart' here is going to change so we probably want to pull that
out
> > and make it a parameter.
> 
> @Bob, the difference is that the one in bot.py is building the sdk, whereas
this
> is building the android target, not the sdk. 

Ah, that makes sense. I didn't notice the target was different too. Does the
Android bot not need the SDK built at all?

[gram, 2012-10-25 16:34:56]

Right now the only Android build target that I know works is "dart".  That's why
that is the target. To answer your question Emily - some time soonish we will
have a new "Dart host" shared library that will be the target (and we will
likely take that and use it from projects in Eclipse), and a bit later that may
become a Dart Android service target and apk. So the target name will change -
"dart" is the command line VM so we won't repurpose it, we will probably end up
with targets like "dart-library", "dart-service", "dart-service-apk", etc. But
this is all TBD.



On 2012/10/25 16:12:16, Bob Nystrom wrote:
> https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
> File tools/bots/android.py (right):
> 
>
https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
> tools/bots/android.py:50: '--os=android dart']
> On 2012/10/25 01:33:34, Emily Fortuna wrote:
> > On 2012/10/25 00:51:36, gram wrote:
> > > The target 'dart' here is going to change so we probably want to pull that
> out
> > > and make it a parameter.
> > 
> > @Bob, the difference is that the one in bot.py is building the sdk, whereas
> this
> > is building the android target, not the sdk. 
> 
> Ah, that makes sense. I didn't notice the target was different too. Does the
> Android bot not need the SDK built at all?

[gram, 2012-10-25 16:39:50]

Actually the names would be more like "android-service", not "dart-service" :-)

On 2012/10/25 16:34:56, gram wrote:
> Right now the only Android build target that I know works is "dart".  That's
why
> that is the target. To answer your question Emily - some time soonish we will
> have a new "Dart host" shared library that will be the target (and we will
> likely take that and use it from projects in Eclipse), and a bit later that
may
> become a Dart Android service target and apk. So the target name will change -
> "dart" is the command line VM so we won't repurpose it, we will probably end
up
> with targets like "dart-library", "dart-service", "dart-service-apk", etc. But
> this is all TBD.
> 
> 
> 
> On 2012/10/25 16:12:16, Bob Nystrom wrote:
> > https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
> > File tools/bots/android.py (right):
> > 
> >
>
https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
> > tools/bots/android.py:50: '--os=android dart']
> > On 2012/10/25 01:33:34, Emily Fortuna wrote:
> > > On 2012/10/25 00:51:36, gram wrote:
> > > > The target 'dart' here is going to change so we probably want to pull
that
> > out
> > > > and make it a parameter.
> > > 
> > > @Bob, the difference is that the one in bot.py is building the sdk,
whereas
> > this
> > > is building the android target, not the sdk. 
> > 
> > Ah, that makes sense. I didn't notice the target was different too. Does the
> > Android bot not need the SDK built at all?

[Emily Fortuna, 2012-10-25 18:19:38]

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/2001/tools/bots/android.py#newc...
tools/bots/android.py:50: '--os=android dart']
On 2012/10/25 16:12:16, Bob Nystrom wrote:
> On 2012/10/25 01:33:34, Emily Fortuna wrote:
> > On 2012/10/25 00:51:36, gram wrote:
> > > The target 'dart' here is going to change so we probably want to pull that
> out
> > > and make it a parameter.
> > 
> > @Bob, the difference is that the one in bot.py is building the sdk, whereas
> this
> > is building the android target, not the sdk. 
> 
> Ah, that makes sense. I didn't notice the target was different too. Does the
> Android bot not need the SDK built at all?

@Bob Apparently not (?) (Graham feel free to correct me)

https://codereview.chromium.org/11264019/diff/11002/tools/bots/android.py
File tools/bots/android.py (right):

https://codereview.chromium.org/11264019/diff/11002/tools/bots/android.py#new...
tools/bots/android.py:48: targets = ['dart']
at graham's request -- pulling out the target(s) separately from the rest of the
command.

[Bob Nystrom, 2012-10-25 20:17:37]

LGTM!