Show tooltip with local variable value in Observatory debugger

Show tooltip with local variable value in Observatory debugger

- Add LocalVariableAnnotation to script-inset
- Tweak shortName for a closure
- Teach Script how to find local variable locations (not perfect yet)
- Send tokenPos and endTokenPos for debugger local variables

Performance improvements:
- Reduced script-inset update/computeAnnotations calls from 5 to 1 for each stack frame that is opened

R=rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45725

[Cutch, 2015-05-11 14:17:20]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-05-11 17:59:36]

lgtm w/c

https://chromiumcodereview.appspot.com/1126363005/diff/60001/runtime/observat...
File runtime/observatory/lib/src/service/object.dart (right):

https://chromiumcodereview.appspot.com/1126363005/diff/60001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:2356: List<LocalVarLocation>
scanLineForLocalVariableLocationse(Pattern pattern,
Locationse -> Locations

https://chromiumcodereview.appspot.com/1126363005/diff/60001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:2387: //
[scanLineForLocalVariableLocationse].
I was going to suggest match groups here. Then I saw match groups don't track
their positions :(

https://chromiumcodereview.appspot.com/1126363005/diff/60001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:2397: 
Bail out if [last]line/column are null. See below.

https://chromiumcodereview.appspot.com/1126363005/diff/60001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:2431: while (line < (lastLine -
1)) {
line and lastLine can be null, so the subtraction here causes a NSM and the
script for the frame isn't displayed.

[Cutch, 2015-05-12 02:41:21]

https://codereview.chromium.org/1126363005/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1126363005/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:2387: //
[scanLineForLocalVariableLocationse].
On 2015/05/11 17:59:36, rmacnak wrote:
> I was going to suggest match groups here. Then I saw match groups don't track
> their positions :(

Acknowledged.

https://codereview.chromium.org/1126363005/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:2397: 
On 2015/05/11 17:59:36, rmacnak wrote:
> Bail out if [last]line/column are null. See below.

Done.

https://codereview.chromium.org/1126363005/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:2431: while (line < (lastLine -
1)) {
On 2015/05/11 17:59:36, rmacnak wrote:
> line and lastLine can be null, so the subtraction here causes a NSM and the
> script for the frame isn't displayed.

Acknowledged.

[Cutch, 2015-05-12 02:41:56]

Committed patchset #5 (id:80001) manually as 45725 (presubmit successful).