Fixes documentation generation for dart:html.

Fixes documentation generation for dart:html.

Specifically, this looks at the canonical URI for a library, and if it begins
with dart:, then use the canonical path as the printed name, otherwise use the
simpleName, which is generally the library name.

This was necessary because the new import syntax changed the simpleName from
say "dart:html" to "html". This should work for all other libraries, too, which
will be updated to the new import syntax in following CLs.

Committed: https://code.google.com/p/dart/source/detail?r=14040

[Andrei Mouravski, 2012-10-24 20:44:34]

Wasn't sure who'd be best to review this so scattershot it is.

[Bob Nystrom, 2012-10-24 20:52:15]

https://codereview.chromium.org/11263020/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11263020/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:93: String printedName(LibraryMirror library) {
"printed" might be a bit too specific. Maybe "displayName"?

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:354: if (doc.printedName(library)==
'dart:nativewrappers') return;
Space before "==" here and elsewhere.

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/html_diff.dart
File utils/apidoc/html_diff.dart (right):

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/html_diff.dart#n...
utils/apidoc/html_diff.dart:101: print('NOOOO');
Debug code. Remove. :)

[dgrove, 2012-10-24 21:06:22]

LGTM once you address Bob's comments/

[Andrei Mouravski, 2012-10-24 21:19:36]

PTAL.

https://codereview.chromium.org/11263020/diff/1/pkg/dartdoc/lib/dartdoc.dart
File pkg/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11263020/diff/1/pkg/dartdoc/lib/dartdoc.dart#...
pkg/dartdoc/lib/dartdoc.dart:93: String printedName(LibraryMirror library) {
On 2012/10/24 20:52:15, Bob Nystrom wrote:
> "printed" might be a bit too specific. Maybe "displayName"?

Done.

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/apidoc.dart#newc...
utils/apidoc/apidoc.dart:354: if (doc.printedName(library)==
'dart:nativewrappers') return;
On 2012/10/24 20:52:15, Bob Nystrom wrote:
> Space before "==" here and elsewhere.

Done.

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/html_diff.dart
File utils/apidoc/html_diff.dart (right):

https://codereview.chromium.org/11263020/diff/1/utils/apidoc/html_diff.dart#n...
utils/apidoc/html_diff.dart:101: print('NOOOO');
On 2012/10/24 20:52:15, Bob Nystrom wrote:
> Debug code. Remove. :)

NOOOOOOOOOO!


Done.

[Bob Nystrom, 2012-10-24 21:21:01]

LGTM!

[Johnni Winther, 2012-12-17 14:43:40]

Please don't modify the mirrors API within adding me as a reviewer. The
compile-time mirrors implementation should be in sync with and at some point in
time merged with dart:mirror and it should therefore not be extended
independently.