Issue 11262029: Add implementation class of InvocationMirror for VM.

Issue 11262029: Add implementation class of InvocationMirror for VM. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add implementation class of InvocationMirror for VM. Committed: https://code.google.com/p/dart/source/detail?r=14063

Patch Set 2 : Addressed review comments. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	A	runtime/lib/invocation_mirror_patch.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
	M	runtime/lib/lib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror_patch.dart File runtime/lib/invocation_mirror_patch.dart (right): https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror_patch.dart#newcode11 runtime/lib/invocation_mirror_patch.dart:11: final int _type; // 0 : Method I ...

8 years, 1 month ago (2012-10-25 08:26:57 UTC) #2

Mads Ager (google)

https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror_patch.dart File runtime/lib/invocation_mirror_patch.dart (right): https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror_patch.dart#newcode6 runtime/lib/invocation_mirror_patch.dart:6: static final int METHOD = 0; Make these private!

8 years, 1 month ago (2012-10-25 08:27:32 UTC) #3

Lasse Reichstein Nielsen

8 years, 1 month ago (2012-10-25 08:42:40 UTC) #4

https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror...
File runtime/lib/invocation_mirror_patch.dart (right):

https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:6: static final int METHOD = 0;
They are statics inside a private class. There is no way to get to them from
outside the library.

https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:11: final int _type;  // 0 : Method
On 2012/10/25 08:26:57, Mads Ager wrote:
> I don't understand the comment? Remove?

Absolutely. Was writing a comment and decided to add constants instead.

> Could you move this private field to a separate group from the public ones?

Done.

https://codereview.chromium.org/11262029/diff/1/runtime/lib/invocation_mirror...
runtime/lib/invocation_mirror_patch.dart:21: 
On 2012/10/25 08:26:57, Mads Ager wrote:
> Remove extra empty line.

Done.

Expand Messages | Collapse Messages