Issue 11262028: Testing support for running tests minified in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11262028: Testing support for running tests minified in dart2js. (Closed)

Created:
8 years, 2 months ago by ricow1

Modified:
8 years, 1 month ago

Reviewers:
erikcorry, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Testing support for running tests minified in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=14071

Patch Set 3 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -8 lines)			Patch
M	tools/bots/bot.py	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	tools/bots/compiler.py	View	1 2	5 chunks	+10 lines, -4 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/11262028/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/11262028/diff/1/tools/testing/dart/test_options.dart#newcode481 tools/testing/dart/test_options.dart:481: configuration['nominify'] = !configuration['nominify']; I think the right-hand side should ...

8 years, 2 months ago (2012-10-25 08:56:31 UTC) #3

LGTM!

Expand Messages | Collapse Messages

Issue 11262028: Testing support for running tests minified in dart2js. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages