Issue 11262025: Check class instruction supports Smi check. This fixes missed inlining of isOdd/isEven

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11262025: Check class instruction supports Smi check. This fixes missed inlining of isOdd/isEven (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check class instruction supports Smi check. This fixes missed inlining of isOdd/isEven Fixed a nasty bug in equality optimization. Make sure that we emit CheckSmiInstr instead of CheckClassInstr if we are only checking for smi. Committed: https://code.google.com/p/dart/source/detail?r=14098

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -20 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	6 chunks	+18 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Added more code  and fixed a bug (see updated comments)

Expand Messages | Collapse Messages