Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 11262017: Update status file for ie10 html tests. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna
Modified:
8 years, 1 month ago
Reviewers:
gram, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status file for ie10 html tests. Committed: https://code.google.com/p/dart/source/detail?r=14044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M tests/html/html.status View 1 chunk +38 lines, -2 lines 0 comments Download
M tools/testing/webdriver_test_setup.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
8 years, 1 month ago (2012-10-24 21:29:38 UTC) #1
gram
On 2012/10/24 21:29:38, Emily Fortuna wrote: Can you explain what the changes are for in ...
8 years, 1 month ago (2012-10-24 21:49:10 UTC) #2
blois
lgtm
8 years, 1 month ago (2012-10-24 21:49:12 UTC) #3
Emily Fortuna
8 years, 1 month ago (2012-10-24 21:53:57 UTC) #4
On 2012/10/24 21:49:10, gram wrote:
> On 2012/10/24 21:29:38, Emily Fortuna wrote:
> 
> Can you explain what the changes are for in the .py file? They seem to be
> related to Opera, not IE, and have nothing to do with the subject of the CL.

Yes, I discovered a bug in that script when I was trying to install Opera on one
of the (formerly) IE10 bots. You can see that elsewhere in the script it's
called "accept_func".

Powered by Google App Engine
This is Rietveld 408576698