Refactor handling of compounds.

Refactor handling of compounds.

BUG=
R=asgerf@google.com, karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/e248820e567b7b7827f1830b4294b5904a28dd89

Reverted: https://github.com/dart-lang/sdk/commit/6f6521ccb87420b97f4f246a9cc8019a8d68f5fd

Committed: https://github.com/dart-lang/sdk/commit/8b715cc94bd7c7121007163a4f9b7db7883fe2f7

[Johnni Winther, 2015-05-06 11:26:41]

johnniwinther@google.com changed reviewers:
+ asgerf@google.com

[Johnni Winther, 2015-05-12 18:54:24]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com
- asgerf@google.com

[karlklose, 2015-05-13 07:25:59]

Structure LGTM, but the diff in semantic_visitor_mixins 3760-4980 is very hard
to read.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:52: STATIC_FINAL_FIELD,
I would use FINAL as the prefix for all of these variants, that is,
FINAL_STATIC_FIELD here, FINAL_TOPLEVEL_FIELD below, etc.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2074: /// Compound
assignment expression of [rhs] with [operator] reading from a
'reading the closurized super [method] and trying to invoke the non-existing
setter'?

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2094: /// unresolved super
getter and writing to a super [setter].
'an unresolved'/'the non-existing'.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2642: /// Prefix
expression with [operator] reading from a super [method], that is,
Same comments for documentation as with superMethodCompound.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:3380: return null;
Remove 'return null'?

[Johnni Winther, 2015-05-13 08:48:00]

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:52: STATIC_FINAL_FIELD,
On 2015/05/13 07:25:59, karlklose wrote:
> I would use FINAL as the prefix for all of these variants, that is,
> FINAL_STATIC_FIELD here, FINAL_TOPLEVEL_FIELD below, etc.

Done.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2074: /// Compound
assignment expression of [rhs] with [operator] reading from a
On 2015/05/13 07:25:59, karlklose wrote:
> 'reading the closurized super [method] and trying to invoke the non-existing
> setter'?

Done.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2094: /// unresolved super
getter and writing to a super [setter].
On 2015/05/13 07:25:59, karlklose wrote:
> 'an unresolved'/'the non-existing'.

Done.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2642: /// Prefix
expression with [operator] reading from a super [method], that is,
On 2015/05/13 07:25:59, karlklose wrote:
> Same comments for documentation as with superMethodCompound.

Done.

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right):

https://codereview.chromium.org/1126173002/diff/40001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:3380: return null;
On 2015/05/13 07:25:59, karlklose wrote:
> Remove 'return null'?

It would add a hint of missing return :(

[Johnni Winther, 2015-05-18 10:11:24]

PTAL at the last patch

[asgerf, 2015-05-18 10:32:41]

asgerf@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2015-05-18 10:32:42]

Drive-by lgtm for the new structure.

https://codereview.chromium.org/1126173002/diff/100001/pkg/compiler/lib/src/c...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1126173002/diff/100001/pkg/compiler/lib/src/c...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1348: setValue: (value)
{}); // The binary operator will throw before this.
This seems wrong. The binary operator will not throw if the constant is
something normal like `5`.

[Johnni Winther, 2015-05-20 08:16:34]

https://codereview.chromium.org/1126173002/diff/100001/pkg/compiler/lib/src/c...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1126173002/diff/100001/pkg/compiler/lib/src/c...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:1348: setValue: (value)
{}); // The binary operator will throw before this.
On 2015/05/18 10:32:42, asgerf wrote:
> This seems wrong. The binary operator will not throw if the constant is
> something normal like `5`.

`5 += 42` is a syntax error that will (and should) not end up in the case.

Changed the name to handleTypeLiteralConstantCompounds.

[Johnni Winther, 2015-05-20 08:38:25]

Committed patchset #8 (id:140001) manually as
e248820e567b7b7827f1830b4294b5904a28dd89 (presubmit successful).

[Johnni Winther, 2015-05-20 11:26:46]

PTAL at the last patch

[karlklose, 2015-05-20 11:35:51]

LGTM.

[Johnni Winther, 2015-05-20 11:52:41]

Committed patchset #12 (id:220001) manually as
8b715cc94bd7c7121007163a4f9b7db7883fe2f7 (presubmit successful).