Improve resolution/codegen separation invariant.

Improve resolution/codegen separation invariant.

BUG=
R=asgerf@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45593

[Johnni Winther, 2015-05-06 10:20:47]

johnniwinther@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2015-05-06 12:57:39]

LGTM

https://codereview.chromium.org/1126163002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1126163002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:195: assert(invariant(element,
Maybe we should add a comment explaining in more detail how to proceed if the
assertion fails:

// If the assertion fails, the resolution library could be missing a call
// of form registry.registerXXX. Alternatively, the code generation could
// spuriously be adding dependencies on things we know we don't need.

[Johnni Winther, 2015-05-07 13:23:09]

https://codereview.chromium.org/1126163002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1126163002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:195: assert(invariant(element,
On 2015/05/06 12:57:39, asgerf wrote:
> Maybe we should add a comment explaining in more detail how to proceed if the
> assertion fails:
> 
> // If the assertion fails, the resolution library could be missing a call
> // of form registry.registerXXX. Alternatively, the code generation could
> // spuriously be adding dependencies on things we know we don't need.

Done.

[Johnni Winther, 2015-05-07 13:30:35]

Committed patchset #2 (id:20001) manually as 45593 (presubmit successful).