Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 11260031: Issue 6202. Remove support for 'Dynamic'. Add Clean Up to rename to 'dynamic'. (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 6202. Remove support for 'Dynamic'. Add Clean Up to rename to 'dynamic'. http://code.google.com/p/dart/issues/detail?id=6202 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -156 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 2 chunks +1 line, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +2 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/Types.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 2 chunks +6 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 13 chunks +13 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/InterfaceTypeImpl.java View 1 chunk +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/InterfaceType.java View 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/ast/NameOccurrencesFinderTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java View 3 chunks +0 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/CleanUpRefactoringWizard.java View 5 chunks +5 lines, -7 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M2_renameExceptions_CleanUp.java View 1 chunk +0 lines, -74 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M2_renameTypes_CleanUp.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/MigrateCleanUpTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 1 month ago (2012-10-25 16:20:38 UTC) #1
Brian Wilkerson
8 years, 1 month ago (2012-10-25 16:25:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698