Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 112593003: Fix building on Mac OS (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix building on Mac OS Use VOID_TEMP_FAILURE_RETRY macro on Linux and Android as well when the return value is not used.. TBR=ajohnsen@google.com Fix analyzer errors in UDP test and update comment in status file TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31101

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/bin/socket_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years ago (2013-12-12 16:18:53 UTC) #1
Søren Gjesse
Committed patchset #2 manually as r31101 (presubmit successful).
7 years ago (2013-12-12 16:20:22 UTC) #2
Anders Johnsen
7 years ago (2013-12-12 16:21:12 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698