Add an [unorderedMatches] matcher to unittest.

Add an [unorderedMatches] matcher to unittest.

This is like [unorderedEquals], but it instead takes an iterable of
matchers and asserts that elements in the actual value match the
matchers.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31178

[Siggi Cherem (dart-lang), 2013-12-17 00:32:03]

lgtm, with comments below

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
File pkg/unittest/lib/src/iterable_matchers.dart (right):

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
pkg/unittest/lib/src/iterable_matchers.dart:138: List<bool> matched = new
List<bool>(actualLength);
might be worth adjusting this too (use the filled constructor like you did
below)

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
pkg/unittest/lib/src/iterable_matchers.dart:205: class _UnorderedMatches extends
Matcher {
seems like there is a lot of code in common here and with _UnorderedEquals. Is
there any way we could combine some of this code? For example, pass in a
equality sub-matcher here as a default?

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/pubspec.yaml
File pkg/unittest/pubspec.yaml (right):

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/pubspec.yaml#ne...
pkg/unittest/pubspec.yaml:2: version: 0.9.2 # Patch version bumped since last
release
we've been following the approach of using 0.9.2-dev if it hasn't been released,
and 0.9.2 once it's released.

This makes it clear that if you depend on this package in another package, your
constraint will reveal that this dependency needs to be released too.

[nweiz, 2013-12-17 03:33:47]

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
File pkg/unittest/lib/src/iterable_matchers.dart (right):

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
pkg/unittest/lib/src/iterable_matchers.dart:205: class _UnorderedMatches extends
Matcher {
On 2013/12/17 00:32:03, Siggi Cherem (dart-lang) wrote:
> seems like there is a lot of code in common here and with _UnorderedEquals. Is
> there any way we could combine some of this code? For example, pass in a
> equality sub-matcher here as a default?

I intentionally avoided going too deep on modifying existing unittest stuff,
since it's nearing the end of its life and it seemed like it wouldn't be effort
well-spent. If you'd like me to, I can, but I don't think it will provide much
value.

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/pubspec.yaml
File pkg/unittest/pubspec.yaml (right):

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/pubspec.yaml#ne...
pkg/unittest/pubspec.yaml:2: version: 0.9.2 # Patch version bumped since last
release
On 2013/12/17 00:32:03, Siggi Cherem (dart-lang) wrote:
> we've been following the approach of using 0.9.2-dev if it hasn't been
released,
> and 0.9.2 once it's released.
> 
> This makes it clear that if you depend on this package in another package,
your
> constraint will reveal that this dependency needs to be released too.

As per our discussion, I'll remove the comment here. I won't add "-dev" since I
intend to release the package immediately anyway.

[nweiz, 2013-12-17 03:34:06]

Committed patchset #1 manually as r31178 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-12-17 18:48:44]

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
File pkg/unittest/lib/src/iterable_matchers.dart (right):

https://codereview.chromium.org/112583003/diff/1/pkg/unittest/lib/src/iterabl...
pkg/unittest/lib/src/iterable_matchers.dart:205: class _UnorderedMatches extends
Matcher {
On 2013/12/17 03:33:47, nweiz wrote:
> On 2013/12/17 00:32:03, Siggi Cherem (dart-lang) wrote:
> > seems like there is a lot of code in common here and with _UnorderedEquals.
Is
> > there any way we could combine some of this code? For example, pass in a
> > equality sub-matcher here as a default?
> 
> I intentionally avoided going too deep on modifying existing unittest stuff,
> since it's nearing the end of its life and it seemed like it wouldn't be
effort
> well-spent. If you'd like me to, I can, but I don't think it will provide much
> value.

I think it is worth the effort for the matchers library.

I agree that unittest needs to be rewritten and we shouldn't try to change it
much, but I had that in mind only for the core of unittest (the running logic
and declarations). I think 'matchers' and 'mock' are fine as they are, or can be
upgraded incrementally, so we should keep maintaining them. I actually thought
we will pull them into separate packages and let unittest (and any future
testing package) re-export them.