Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1125813004: Support 'on T' catch clauses and multiple clauses. (Closed)

Created:
5 years, 7 months ago by Kevin Millikin (Google)
Modified:
5 years, 7 months ago
Reviewers:
asgerf, karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Support 'on T' catch clauses and multiple clauses. The sequence of clauses is translated into the corresponding nested if-else statements. The last else is the catch-all clause (no 'on T') if there is one or implicitly 'rethrow' otherwise. If there is a catch-all clause (no 'on T'), then any clauses after it are unreachable. The language specification allows such unreachable clauses without an error. R=asgerf@google.com, karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45634

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -59 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 2 chunks +72 lines, -32 lines 1 comment Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M tests/co19/co19-dart2js.status View 7 chunks +0 lines, -8 lines 0 comments Download
M tests/language/language_dart2js.status View 7 chunks +0 lines, -9 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Google)
5 years, 7 months ago (2015-05-05 10:25:50 UTC) #1
Kevin Millikin (Google)
I inspected the JS output of most of the now-passing tests, it is correct but ...
5 years, 7 months ago (2015-05-05 10:29:12 UTC) #2
asgerf
LGTM!
5 years, 7 months ago (2015-05-05 10:39:28 UTC) #3
Kevin Millikin (Google)
5 years, 7 months ago (2015-05-08 08:49:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698