Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1125803002: Revert parts of r45502 and always generate guard field instructions. (Closed)

Created:
5 years, 7 months ago by Florian Schneider
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert parts of r45502 and always generate guard field instructions. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +13 lines, -24 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
tbr
5 years, 7 months ago (2015-05-04 20:21:57 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years, 7 months ago (2015-05-04 20:30:02 UTC) #3
Florian Schneider
5 years, 7 months ago (2015-05-04 20:32:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698