Issue 1125613003: Make sure to visit function annotations in ElementBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125613003: Make sure to visit function annotations in ElementBuilder. (Closed)

Created:
5 years, 7 months ago by Paul Berry

Modified:
5 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Make sure to visit function annotations in ElementBuilder. Since r44861, ElementBuilder is responsible for creating the ConstantInstanceCreationHandle objects associated with InstanceCreationExpressions. Since InstanceCreationExpressions may appear inside annotations, we must make sure the ElementBuilder visits all annotations. Previous to this change, it didn't visit function annotations. BUG=dartbug.com/23354 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45489

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -1 line)			Patch
M	pkg/analyzer/lib/src/generated/resolver.dart	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/non_error_resolver_test.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	tests/language/instance_creation_in_function_annotation_test.dart	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 7 months ago (2015-05-04 13:25:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45489 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages