Add a task to the new task model for computing constant values.

Add a task to the new task model for computing constant values.

Not yet implemented: proper handling of circular references.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45651

[Paul Berry, 2015-05-08 18:39:04]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2015-05-08 18:46:08]

LGTM

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:1648: // are computed first.
Should this comment be removed?

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
File pkg/analyzer/lib/src/task/general.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
pkg/analyzer/lib/src/task/general.dart:69: abstract class
ElementBasedAnalysisTask extends AnalysisTask {
I'm not sure that this is a right place for this task.
Elements are probably too Dart specific.
Maybe move it to src/dart.dart ?

[Brian Wilkerson, 2015-05-08 19:22:39]

LGTM

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:182: * TODO(paulberry): is
ELEMENT_CACHING_POLICY the correct caching policy?
Long term, probably not. But I don't think it will hurt anything today.

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:184: final ResultDescriptor<Element>
CONSTANT_EVALUATED_ELEMENT = new
ResultDescriptor<Element>('CONST_EVALUATED_ELEMENT', null, cachingPolicy:
ELEMENT_CACHING_POLICY);
Perhaps format the file?

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
File pkg/analyzer/lib/src/task/general.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
pkg/analyzer/lib/src/task/general.dart:69: abstract class
ElementBasedAnalysisTask extends AnalysisTask {
> Maybe move it to src/dart.dart ?

Agreed.

[Paul Berry, 2015-05-08 19:44:23]

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:182: * TODO(paulberry): is
ELEMENT_CACHING_POLICY the correct caching policy?
On 2015/05/08 19:22:38, Brian Wilkerson wrote:
> Long term, probably not. But I don't think it will hurt anything today.

Ok, I will leave the TODO message as a reminder to revisit the question.

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:184: final ResultDescriptor<Element>
CONSTANT_EVALUATED_ELEMENT = new
ResultDescriptor<Element>('CONST_EVALUATED_ELEMENT', null, cachingPolicy:
ELEMENT_CACHING_POLICY);
On 2015/05/08 19:22:38, Brian Wilkerson wrote:
> Perhaps format the file?

Done.

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:1648: // are computed first.
On 2015/05/08 18:46:07, scheglov wrote:
> Should this comment be removed?

I think it should stay.  I was trying to explain why it's not necessary for the
task to access inputs[DEPENDENCIES_INPUT].

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
File pkg/analyzer/lib/src/task/general.dart (right):

https://codereview.chromium.org/1125423004/diff/1/pkg/analyzer/lib/src/task/g...
pkg/analyzer/lib/src/task/general.dart:69: abstract class
ElementBasedAnalysisTask extends AnalysisTask {
On 2015/05/08 18:46:08, scheglov wrote:
> I'm not sure that this is a right place for this task.
> Elements are probably too Dart specific.
> Maybe move it to src/dart.dart ?

Done.

[Paul Berry, 2015-05-08 19:44:52]

Committed patchset #1 (id:1) manually as 45651 (presubmit successful).