Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1125303008: Tweaks for using task model in Editor. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Tweaks for using task model in Editor. It works in general, bug currently it is buggy and slow. Notes: 1. Implicit dependencies backfire. If the cache size is not big enough and we end up flushing some CU, then recreating it, it looses its LibraryElement. We need an explicit dependency on it. 2. If the cache size is not big enough, this still may cause an infinite analysis cycle. 3. We need to implement activating / deactivating cache partitions to change cache size. 4. Probably we need to set LineInfo into ChangeNotice always. 5. There are bugs in type hierarchy. 6. Semantic highlighting takes too long to display. 7. Overlay changes are not used. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +19 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-14 16:55:04 UTC) #1
Brian Wilkerson
LGTM, at least as a temporary work-around
5 years, 7 months ago (2015-05-14 22:01:28 UTC) #2
scheglov
5 years, 7 months ago (2015-05-15 15:04:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45811 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698