Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1125123006: Add a "librarySource" field to CompilationUnitElementImpl. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add a "librarySource" field to CompilationUnitElementImpl. This fixes a dependency problem in ComputeConstantDependenciesTask. Prevously it used element.library.source to get access to the library source, but this created an implicit dependency on LIBRARY_ELEMENT1 (since element.library is null if the library element hasn't been built yet). There was no way to make that dependency explicit since previous to this change, the CompilationUnitElement did not store enough information to determine what library it was part of until after the library element had been created. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -37 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +13 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/task_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 10 chunks +18 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
Brian-- This addresses the issue we spoke about on IM earlier today.
5 years, 7 months ago (2015-05-08 21:55:19 UTC) #2
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-08 22:08:58 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-09 01:19:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698