Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1124963002: Share code for building recognized native getters. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Share code for building recognized native getters. Internalizing the maps will add a few more of these, so let's avoid duplication. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=45547

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 4 chunks +32 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
koda
5 years, 7 months ago (2015-05-05 18:13:04 UTC) #1
Florian Schneider
dbc: https://codereview.chromium.org/1124963002/diff/40001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1124963002/diff/40001/runtime/vm/flow_graph_builder.cc#newcode3380 runtime/vm/flow_graph_builder.cc:3380: case MethodRecognizer::kBigint_getDigits: { It seems you can also ...
5 years, 7 months ago (2015-05-05 23:47:01 UTC) #3
koda
https://codereview.chromium.org/1124963002/diff/40001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/1124963002/diff/40001/runtime/vm/flow_graph_builder.cc#newcode3380 runtime/vm/flow_graph_builder.cc:3380: case MethodRecognizer::kBigint_getDigits: { On 2015/05/05 23:47:01, Florian Schneider wrote: ...
5 years, 7 months ago (2015-05-06 00:20:45 UTC) #4
Florian Schneider
LGTM. Thanks for this clean-up.
5 years, 7 months ago (2015-05-06 00:25:44 UTC) #5
koda
5 years, 7 months ago (2015-05-06 02:50:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r45547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698