Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1124713003: Implement bigint shift intrinsics on arm64. (Closed)

Created:
5 years, 7 months ago by regis
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement bigint shift intrinsics on arm64. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45521

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -2 lines) Patch
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +84 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 7 months ago (2015-05-04 15:36:16 UTC) #2
Cutch
lgtm https://codereview.chromium.org/1124713003/diff/1/runtime/vm/intrinsifier_arm64.cc File runtime/vm/intrinsifier_arm64.cc (right): https://codereview.chromium.org/1124713003/diff/1/runtime/vm/intrinsifier_arm64.cc#newcode730 runtime/vm/intrinsifier_arm64.cc:730: __ ldr(R0, Address(R7, -2 * Bigint::kBytesPerDigit, Address::PreIndex)); Maybe ...
5 years, 7 months ago (2015-05-04 17:24:45 UTC) #3
regis
Thanks! https://codereview.chromium.org/1124713003/diff/1/runtime/vm/intrinsifier_arm64.cc File runtime/vm/intrinsifier_arm64.cc (right): https://codereview.chromium.org/1124713003/diff/1/runtime/vm/intrinsifier_arm64.cc#newcode730 runtime/vm/intrinsifier_arm64.cc:730: __ ldr(R0, Address(R7, -2 * Bigint::kBytesPerDigit, Address::PreIndex)); On ...
5 years, 7 months ago (2015-05-05 07:31:35 UTC) #4
regis
5 years, 7 months ago (2015-05-05 07:32:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698