Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1124713002: Skip huge array allocation in ARM tests. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Skip huge array allocation in ARM tests. This is suspected to cause flaky C++ OOM crash on the build bot. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=45518

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
5 years, 7 months ago (2015-05-04 15:22:51 UTC) #1
koda
Corrected to (only) skip on non-sim ARM
5 years, 7 months ago (2015-05-04 15:29:40 UTC) #2
ricow1
lgtm
5 years, 7 months ago (2015-05-04 15:29:42 UTC) #3
ricow1
Committed patchset #2 (id:20001) manually as 45518 (presubmit successful).
5 years, 7 months ago (2015-05-05 06:11:53 UTC) #4
ricow1
5 years, 7 months ago (2015-05-05 06:12:06 UTC) #5
Message was sent while issue was closed.
I went ahead and landed this

Powered by Google App Engine
This is Rietveld 408576698