Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 112433002: update our CustomElement+Shadow DOM patch (Closed)

Created:
7 years ago by Jennifer Messerly
Modified:
7 years ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -5 lines) Patch
M pkg/custom_element/lib/custom-elements.debug.js View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/custom_element/lib/custom-elements.min.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/custom_element/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/polymer/test/entered_view_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download
A pkg/polymer/test/entered_view_test.html View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
update: now has a test, also bumped polymer's dependency to encourage upgrading
7 years ago (2013-12-11 04:49:49 UTC) #1
blois
lgtm
7 years ago (2013-12-11 16:29:57 UTC) #2
Jennifer Messerly
7 years ago (2013-12-11 20:31:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698