Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124223008: remove matcher from try site - matcher is now part of unittest (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

remove matcher from try site - matcher is now part of unittest TBR Committed: https://code.google.com/p/dart/source/detail?r=45663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M site/try/app.yaml View 1 chunk +0 lines, -4 lines 0 comments Download
M site/try/build_try.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 7 months ago (2015-05-08 21:55:01 UTC) #2
kevmoo
Committed patchset #1 (id:1) manually as 45663 (presubmit successful).
5 years, 7 months ago (2015-05-08 21:55:22 UTC) #3
ahe
5 years, 7 months ago (2015-05-12 07:23:57 UTC) #4
Message was sent while issue was closed. 
lgtm

Compatibility is hard.

Powered by Google App Engine
This is Rietveld 408576698