Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1124193004: Add embedded_dart_io source_set for Sky (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add embedded_dart_io source_set for Sky BUG= R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=45576

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +60 lines, -0 lines 0 comments Download
A runtime/bin/embedded_dart_io.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A runtime/bin/embedded_dart_io.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 7 months ago (2015-05-06 21:30:59 UTC) #2
rmacnak
lgtm
5 years, 7 months ago (2015-05-06 21:35:59 UTC) #3
Cutch
5 years, 7 months ago (2015-05-06 21:36:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698