Issue 11239004: Move DualPivotQuicksort from coreimpl to core as _Sort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11239004: Move DualPivotQuicksort from coreimpl to core as _Sort. (Closed)

Created:
8 years, 2 months ago by Anders Johnsen

Modified:
8 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Mads Ager (google), Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move DualPivotQuicksort from coreimpl to core as _Sort. I've added a tempoary coreSort method in core, to coreimpl and other uses, until the move is done. BUG= Committed: https://code.google.com/p/dart/source/detail?r=13993

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add note #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -352 lines)			Patch
M	lib/compiler/implementation/lib/interceptors.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/core/core.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/core/corelib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	lib/core/sort.dart	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/dual_pivot_quicksort.dart	View		1 chunk	+0 lines, -342 lines	0 comments	Download
M	runtime/lib/array.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/byte_array.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/sort_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11239004/diff/1/lib/core/sort.dart File lib/core/sort.dart (right): https://codereview.chromium.org/11239004/diff/1/lib/core/sort.dart#newcode6 lib/core/sort.dart:6: void coreSort(List l, int compare(a, b)) => _Sort.sort(l, ...

8 years, 2 months ago (2012-10-23 17:25:29 UTC) #2

Anders Johnsen

8 years, 2 months ago (2012-10-23 17:33:00 UTC) #3

Thank you, landing.

https://codereview.chromium.org/11239004/diff/1/lib/core/sort.dart
File lib/core/sort.dart (right):

https://codereview.chromium.org/11239004/diff/1/lib/core/sort.dart#newcode6
lib/core/sort.dart:6: void coreSort(List l, int compare(a, b)) => _Sort.sort(l,
compare);
On 2012/10/23 17:25:29, floitsch wrote:
> Add a dartdoc explaining that this method will go away soon and is not
intended
> for public use.

Done.

Expand Messages | Collapse Messages