Issue 11236063: Restructure code generation timers and add sub-timers for inlining phases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11236063: Restructure code generation timers and add sub-timers for inlining phases. (Closed)

Created:
8 years, 2 months ago by zerny-google

Modified:
8 years, 2 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Restructure code generation timers and add sub-timers for inlining phases. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=13927

Patch Set 1 #

Total comments: 2

Patch Set 2 : Names and copyright #

Patch Set 3 : Include and declare #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -109 lines)			Patch
M	runtime/vm/compiler.cc	View	1	1 chunk	+83 lines, -72 lines	0 comments	Download
M	runtime/vm/compiler_stats.h	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
M	runtime/vm/compiler_stats.cc	View	1	2 chunks	+46 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 2	6 chunks	+61 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 2 months ago (2012-10-23 07:54:56 UTC) #2

LGTM with a naming change.

https://codereview.chromium.org/11236063/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/11236063/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:164: &CompilerStats::graphssa_timer,
Needs to be graph_ssa_timer.  Could it be just CompilerStats::ssa_timer?

https://codereview.chromium.org/11236063/diff/1/runtime/vm/compiler_stats.h
File runtime/vm/compiler_stats.h (right):

https://codereview.chromium.org/11236063/diff/1/runtime/vm/compiler_stats.h#n...
runtime/vm/compiler_stats.h:1: // Copyright (c) 2012, the Dart project authors. 
Please see the AUTHORS file
I'm not sure we do this any more.  Let me ask.

Expand Messages | Collapse Messages