Issue 11236034: Fix version script for git repos that are not git-svn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11236034: Fix version script for git repos that are not git-svn. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
ricow1, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix version script for git repos that are not git-svn. R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13921

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
	M	runtime/tools/make_version.py	View		1 chunk	+17 lines, -13 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM cc'ing Ivan since this is his script. We should probably do the same thing ...

8 years, 2 months ago (2012-10-22 18:23:40 UTC) #2

Ivan Posva

https://codereview.chromium.org/11236034/diff/1/runtime/tools/make_version.py File runtime/tools/make_version.py (right): https://codereview.chromium.org/11236034/diff/1/runtime/tools/make_version.py#newcode38 runtime/tools/make_version.py:38: git_proc = subprocess.Popen( I know this was already an ...

8 years, 1 month ago (2012-10-26 02:57:06 UTC) #3

Mads Ager (google)

8 years, 1 month ago (2012-10-26 06:26:46 UTC) #4

https://codereview.chromium.org/11236034/diff/1/runtime/tools/make_version.py
File runtime/tools/make_version.py (right):

https://codereview.chromium.org/11236034/diff/1/runtime/tools/make_version.py...
runtime/tools/make_version.py:38: git_proc = subprocess.Popen(
On 2012/10/26 02:57:06, Ivan Posva wrote:
> I know this was already an issue previously: What if this is not a git
checkout
> either? But now you just get an exception thrown out of this function. Not
good.

Yeah, I actually did remove a try: block from here. I should put it back. Wrap
this entire else: in a try: block and catch the exceptions. Thanks.

Expand Messages | Collapse Messages