Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 11236024: Merge ListLikeIDLTypeInfo into InterfaceIDLType and add other list-like types to the registry. (Closed)

Created:
8 years, 2 months ago by podivilov
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Merge ListLikeIDLTypeInfo into InterfaceIDLType and add other list-like types to the registry. The merge is needed to get html renames and svg tear-off support for list-like types. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=13872

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -66 lines) Patch
M lib/html/scripts/generator.py View 1 11 chunks +97 lines, -66 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 2 months ago (2012-10-22 10:44:29 UTC) #1
Anton Muhin
https://codereview.chromium.org/11236024/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11236024/diff/1/lib/html/scripts/generator.py#newcode912 lib/html/scripts/generator.py:912: list_like=False, item_type=None, suppress_interface=False): cannot we assume item_type is None ...
8 years, 2 months ago (2012-10-22 12:19:18 UTC) #2
podivilov
https://codereview.chromium.org/11236024/diff/1/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/11236024/diff/1/lib/html/scripts/generator.py#newcode912 lib/html/scripts/generator.py:912: list_like=False, item_type=None, suppress_interface=False): On 2012/10/22 12:19:18, Anton Muhin wrote: ...
8 years, 2 months ago (2012-10-22 12:32:59 UTC) #3
Anton Muhin
8 years, 2 months ago (2012-10-22 12:49:21 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698